Pivot to pyproject.toml for setuptools packaging #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci] removing python version [ci] fixing concatened dependencies (install_requirements and scm) [ci] Putting back wrongly deleted services start [ci] Fixing ci beceause setuptools and setuptools-scm incompatible versions
|
See #893 |
… script cd being built in most unix OS it cannot be called using cd.sh() as there is no existing binary on the machine.
AlexandreDoneux
force-pushed
the
pyproject_toml_setuptools
branch
2 times, most recently
from
313d50d
to
bc5971e
Compare
AlexandreDoneux
force-pushed
the
pyproject_toml_setuptools
branch
from
bc5971e
to
820571a
Compare
|
A discussion is needed regarding the scripts in the INGInious package using docker compose. They are not needed and where ignored conditionnaly with a boolean in setup.py. It is however not possible with the pyproject.toml file. Using two different pyproject.toml files does not seem to be achievable :
So either we accept the presence of unused scripts in the docker compose package (not that many) or we comment the pyproject.toml scripts before building it. |
|
This PR will be reconsidered after the definition of a new backend architecture and services separation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using pyproject.toml is the new standardized way to declare packaging metadata. As it is the new standard there will likely be less problems related to the packaging of INGInious.
Rem : setup.py is still usable and the configuration in pyproject.toml overwrites that of setup.py. For the moment the scripts are left in setup.py because of the condition on INGINIOUS_COMPOSE environment variable that can not be done in toml files.
TO DO :
-> deleted + not using nose testing anymore
sh.CommandNotFound: cd)-> two pyproject.toml files (with and without scripts depending on the use of docker compose or not)